|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v2 5/9] hbitmap: Add hbitmap_copy |
Date: | Thu, 13 Mar 2014 15:28:29 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Il 13/03/2014 14:45, Benoît Canet ha scritto:
This feel wrong: struct HBitmap { /* Number of total bits in the bottom level. */ uint64_t size; The comment about size imply that size apply only to the bottom level. Moreover the bitmaps are progressivelly less coarse so I think the size you use should goes down as you go up to the top.
Correct. You can reuse the computation in hbitmap_alloc instead. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |