Re: [Qemu-devel] [PATCH] xics-kvm: fix reset function

[Andreas Färber]

Am 13.03.2014 00:00, schrieb Alexey Kardashevskiy:
> On 03/13/2014 01:42 AM, Andreas Färber wrote:
>> Am 04.03.2014 08:03, schrieb Alexey Kardashevskiy:
>>> On 02/13/2014 12:08 PM, Alexey Kardashevskiy wrote:
>>>> Currently interrupt priorities are set to 0 (highest) at the very
>>>> beginning of the guest execution which is not correct and makes the guest
>>>> produce random interrupt error messages such as:
>>>> "Interrupt 0x1001 (real) is invalid, disabling it".
>>>> This also prevents interrupt states from correct migration.
>>>>
>>>> This initializes priority to 0xFF as the emulated XICS does.
>>>
>>>
>>> Ping? Pretty simple patch suggested by Paul Mackerras.
>>
>> Is this one still needed? Can we document a Suggested-by?
> 
> Yes.
> 
> Suggested-by: Paul Mackerras <address@hidden>

Thanks, queuing with optimization on my ppc-next:
https://github.com/afaerber/qemu-cpu/commits/ppc-next

diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c
index 04e4e61..c93dae0 100644
--- a/hw/intc/xics_kvm.c
+++ b/hw/intc/xics_kvm.c
@@ -278,7 +278,7 @@ static void ics_kvm_reset(DeviceState *dev)
         ics->irqs[i].saved_priority = 0xff;
     }

-    ics_set_kvm_state(ICS(dev), 1);
+    ics_set_kvm_state(ics, 1);
 }

 static void ics_kvm_realize(DeviceState *dev, Error **errp)

Testing TBD.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg