Re: [Qemu-devel] [RFC PATCH v2 03/12] mc: introduce a 'checkpointing' status check into the VCPU states

[Eric Blake]

On 02/18/2014 01:50 AM, address@hidden wrote:
> From: "Michael R. Hines" <address@hidden>
> 
> During micro-checkpointing, the VCPUs get repeatedly paused and
> resumed. We need to not freak out when the VM begins micro-checkpointing.
> 
> Signed-off-by: Michael R. Hines <address@hidden>
> ---
>  cpus.c                        |  9 ++++++++-
>  include/migration/migration.h | 21 +++++++++++++++++++++
>  qapi-schema.json              |  4 +++-
>  vl.c                          |  7 +++++++
>  4 files changed, 39 insertions(+), 2 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -169,6 +169,8 @@
>  #
>  # @save-vm: guest is paused to save the VM state
>  #
> +# @checkpoint-vm: guest is paused to checkpoint the VM state
> +#

It would be nice to mention '(since 2.1)'.

>  # @shutdown: guest is shut down (and -no-shutdown is in use)
>  #
>  # @suspended: guest is suspended (ACPI S3)
> @@ -181,7 +183,7 @@
>    'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
>              'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm',
>              'running', 'save-vm', 'shutdown', 'suspended', 'watchdog',
> -            'guest-panicked' ] }
> +            'guest-panicked', 'checkpoint-vm' ] }

It would also be nice to document the enum variables in the same order
you declare them.  The declaration of 'checkpoint-vm' does not have to
be at the end; we use named enums precisely so that the QMP interface is
not tied to the C integer value underlying the enum.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature