[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [Bug 1288385] Re: VFIO passthrough causes assertation failu
From: |
bluebird |
Subject: |
[Qemu-devel] [Bug 1288385] Re: VFIO passthrough causes assertation failure |
Date: |
Tue, 11 Mar 2014 18:45:12 -0000 |
commit 6e1f0a55a14bad1d0c8b9d29626ef4e4b2617c74
Author: Igor Mammedov <address@hidden>
Date: Mon Feb 17 15:00:06 2014 +0100
PCIE: fix regression with coldplugged multifunction device
PCIE is causing asserts each time a multifunction device is added
on command line (coldplug).
This is caused by
commit a66e657e18cd9b70e9f57ae5512c07faf2bc508f
pci/pcie: convert PCIE hotplug to use hotplug-handler API
QEMU abort is caused by misplaced assertion, which should
be checked only when device is hotplugged.
Reference to regression report:
http://www.mail-archive.com/address@hidden/msg216226.html
Fixes: a66e657e18cd9b70e9f57ae5512c07faf2bc508f
Reported-By: Nigel Kukard <address@hidden>
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1288385
Title:
VFIO passthrough causes assertation failure
Status in QEMU:
Fix Committed
Bug description:
Since commit 5e95494380ec I am no longer able to passthrough my Nvidia
GTX 770 using VFIO. Qemu terminates with:
qemu-system-x86_64: hw/pci/pcie.c:240: pcie_cap_slot_hotplug_common:
Assertion `((pci_dev->devfn) & 0x07) == 0' failed.
Above output was generated using commit f55ea6297cc0.
Lspci of the vga card:
01:00.0 VGA compatible controller: NVIDIA Corporation GK104 [GeForce GTX 770]
(rev a1)
Subsystem: Gigabyte Technology Co., Ltd Device 360c
Kernel driver in use: vfio-pci
01:00.1 Audio device: NVIDIA Corporation GK104 HDMI Audio Controller (rev a1)
Subsystem: Gigabyte Technology Co., Ltd Device 360c
Kernel driver in use: vfio-pci
Commandline used to start qemu:
qemu-system-x86_64 -machine accel=kvm \
-nodefaults \
-name VFIO-Test \
-machine q35 \
-cpu host \
-smp 1 \
-enable-kvm \
-m 1024 \
-k de \
-vga none \
-device
ioh3420,bus=pcie.0,addr=1c.0,multifunction=on,port=1,chassis=1,id=root.1 \
-device
vfio-pci,host=01:00.0,bus=root.1,addr=00.0,multifunction=on,x-vga=on \
-device vfio-pci,host=01:00.1,bus=root.1,addr=00.1 \
-rtc base=utc \
-boot order=d \
-device ide-cd,drive=drive-cd-disk1,id=cd-disk1,unit=0 \
-drive
file=/home/bluebird/Downloads/systemrescuecd-x86-4.0.0.iso,if=none,id=drive-cd-disk1,media=cdrom
\
-nographic
Full output of git bisect:
5e95494380ecf83c97d28f72134ab45e0cace8f9 is the first bad commit
commit 5e95494380ecf83c97d28f72134ab45e0cace8f9
Author: Igor Mammedov <address@hidden>
Date: Wed Feb 5 16:36:52 2014 +0100
hw/pci: switch to a generic hotplug handling for PCIDevice
make qdev_unplug()/device_set_realized() to call hotplug handler's
plug/unplug methods if available and remove not needed anymore
hot(un)plug handling from PCIDevice.
In case if hotplug handler is not available, revert to the legacy
hotplug method for compatibility with not yet converted buses.
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
:040000 040000 9bdab0d75fbc9be4fe2e4274e58e0cdcd347ac7e
d6d6294ea9c06e80a0fc8fcabd6345dfae5137ad M hw
:040000 040000 d064d75ca8b8f169c41eee2683082e8f9104e968
f2abbf9bee754ada0f49135968455fd1a69b2186 M include
:040000 040000 c515daff6c77f9bd2cc32873be4c5c3a1c20cbb9
c506f5587afe8f7ee129a7ca6e3ae2e5118254f9 M tests
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1288385/+subscriptions
[Prev in Thread] |
Current Thread |
[Next in Thread] |