[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glib
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version |
Date: |
Tue, 11 Mar 2014 18:08:10 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* Jan Kiszka (address@hidden) wrote:
> pthread_setname_np was introduced with 2.12.
>
> Signed-off-by: Jan Kiszka <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
I'll polish a configure/separate function as suggested by Peter;
let's get the simple fix in quickly though to unbreak people
while I do that.
Dave
> ---
> util/qemu-thread-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c
> index 45113b4..960d7f5 100644
> --- a/util/qemu-thread-posix.c
> +++ b/util/qemu-thread-posix.c
> @@ -420,7 +420,7 @@ void qemu_thread_create(QemuThread *thread, const char
> *name,
> if (err)
> error_exit(err, __func__);
>
> -#ifdef _GNU_SOURCE
> +#if defined(__GLIBC__) && (__GLIBC__ > 2 || (__GLIBC__ == 2 &&
> __GLIBC_MINOR__ >= 12))
> if (name_threads) {
> pthread_setname_np(thread->thread, name);
> }
> --
> 1.8.1.1.298.ge7eed54
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version, (continued)
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version, Dr. David Alan Gilbert, 2014/03/11
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version, Peter Maydell, 2014/03/11
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version, Dr. David Alan Gilbert, 2014/03/11
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version, Peter Maydell, 2014/03/11
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version, Michael S. Tsirkin, 2014/03/11
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version, Dr. David Alan Gilbert, 2014/03/11
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version, Peter Maydell, 2014/03/11
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version, Michael S. Tsirkin, 2014/03/11
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version, Peter Maydell, 2014/03/11
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version, Dr. David Alan Gilbert, 2014/03/11
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version,
Dr. David Alan Gilbert <=
- Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version, Peter Maydell, 2014/03/11
- Re: [Qemu-devel] [PULL v3 08/14] Add a 'name' parameter to qemu_thread_create, Dr. David Alan Gilbert, 2014/03/11
[Qemu-devel] [PULL v3 09/14] MAINTAINERS: drop an out of date address, Michael S. Tsirkin, 2014/03/09
[Qemu-devel] [PULL v3 10/14] acpi-test: retain both asl and aml files on failure, Michael S. Tsirkin, 2014/03/09
[Qemu-devel] [PULL v3 11/14] acpi-test: issue errors instead of warnings when possible, Michael S. Tsirkin, 2014/03/09
[Qemu-devel] [PULL v3 12/14] pam: partly fix write-only mode, Michael S. Tsirkin, 2014/03/09
[Qemu-devel] [PULL v3 13/14] pckbd: return 'keyboard enabled' on read input port command, Michael S. Tsirkin, 2014/03/09
[Qemu-devel] [PULL v3 14/14] qemu: x86: ignore ioapic polarity, Michael S. Tsirkin, 2014/03/09
[Qemu-devel] [PULL v3 07/14] Add 'debug-threads' suboption to --name, Michael S. Tsirkin, 2014/03/09
Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Peter Maydell, 2014/03/10