[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] tests/qdev-global-props: fixes due to machi

From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 0/3] tests/qdev-global-props: fixes due to machine conversion to QOM
Date: Tue, 11 Mar 2014 18:11:55 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

Hi Marcel,

Am 11.03.2014 16:35, schrieb Marcel Apfelbaum:
> To be applied on top of:
>     hw/boards: converted current_machine to be an instance of MachineClass
> Rebased for qom-next branch of Andrea's QOM tree.
> Patch 1: allows to assign QEMUMachine "automatically",
>          and not only in vl.c (we need this in tests)
> Patch 2: converts "none-machine" to QOM
> Patch 3: Fixes qdev-global-props by adding the "none-machine"
>          to the tree.
> Cc: Andreas Färber <address@hidden>
> Marcel Apfelbaum (3):
>   hw/machine: move QEMUMachine assignment into the core machine
>   hw/null-machine: Convert null machine to QOM
>   tests/qdev-global-props: Manually add an instance of a QOM machine

It seems I am to blame for most of the problems you are working around
now, so let's not be too shy to correct myself and make things easier on
us. ;)

I'd rather not take the class_base_init patch - for one class_init would
be more correct, but for another I generally don't like putting such
requirements onto use of a base class. The null machine seems indeed low
hanging fruit for further cleanups - but can't we start by making
MachineClass used instead of QEMUMachine? Then we won't need to assign
mc->qemu_machine any more and can start dropping machine_none.


SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]