[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v22 11/25] qcow.c: replace QEMUOptionParameter w
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v22 11/25] qcow.c: replace QEMUOptionParameter with QemuOpts |
|
Date: |
Tue, 11 Mar 2014 11:05:50 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/10/2014 01:31 AM, Chunyan Liu wrote:
> Signed-off-by: Dong Xu Wang <address@hidden>
> Signed-off-by: Chunyan Liu <address@hidden>
> ---
> block/qcow.c | 72
> ++++++++++++++++++++++++++++++------------------------------
> 1 file changed, 36 insertions(+), 36 deletions(-)
See my comments on patch 24 - this commit temporarily breaks the vvfat
driver, which is trying to reuse the qcow create_options member.
> @@ -920,7 +920,7 @@ static BlockDriver bdrv_qcow = {
> .bdrv_write_compressed = qcow_write_compressed,
> .bdrv_get_info = qcow_get_info,
>
> - .create_options = qcow_create_options,
> + .create_opts = &qcow_create_opts,
> };
>
> static void bdrv_qcow_init(void)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature