[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/6] configure: don't modify .status on error
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 3/6] configure: don't modify .status on error |
Date: |
Tue, 11 Mar 2014 14:32:27 +0200 |
./configure --help
make
will try to re-run configure with --help
which isn't what was intended.
The reason is that config.status was written
even on configure error.
Defer writing config.status until configure
has completed successfully.
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
configure | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/configure b/configure
index 8689435..3ae57d7 100755
--- a/configure
+++ b/configure
@@ -31,19 +31,6 @@ printf " '%s'" "$0" "$@" >> config.log
echo >> config.log
echo "#" >> config.log
-# Save the configure command line for later reuse.
-cat <<EOD >config.status
-#!/bin/sh
-# Generated by configure.
-# Run this file to recreate the current configuration.
-# Compiler output produced by configure, useful for debugging
-# configure, is in config.log if it exists.
-EOD
-printf "exec" >>config.status
-printf " '%s'" "$0" "$@" >>config.status
-echo >>config.status
-chmod +x config.status
-
error_exit() {
echo
echo "ERROR: $1"
@@ -5136,3 +5123,17 @@ done
if test "$docs" = "yes" ; then
mkdir -p QMP
fi
+
+# Save the configure command line for later reuse.
+cat <<EOD >config.status
+#!/bin/sh
+# Generated by configure.
+# Run this file to recreate the current configuration.
+# Compiler output produced by configure, useful for debugging
+# configure, is in config.log if it exists.
+EOD
+printf "exec" >>config.status
+printf " '%s'" "$0" "$@" >>config.status
+echo >>config.status
+chmod +x config.status
+
--
MST
- [Qemu-devel] [PULL 0/6] acpi,pc,test bug fixes, Michael S. Tsirkin, 2014/03/11
- [Qemu-devel] [PULL 1/6] loader: rename in_ram/has_mr, Michael S. Tsirkin, 2014/03/11
- [Qemu-devel] [PULL 2/6] pc: avoid duplicate names for ROM MRs, Michael S. Tsirkin, 2014/03/11
- [Qemu-devel] [PULL 3/6] configure: don't modify .status on error,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 5/6] acpi-build: don't access unaligned addresses, Michael S. Tsirkin, 2014/03/11
- [Qemu-devel] [PULL 6/6] acpi-test: update expected SSDT files, Michael S. Tsirkin, 2014/03/11
- [Qemu-devel] [PULL 4/6] q35: Correct typo BRDIGE -> BRIDGE, Michael S. Tsirkin, 2014/03/11
- Re: [Qemu-devel] [PULL 0/6] acpi,pc,test bug fixes, Peter Maydell, 2014/03/12