[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cac
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cache() |
|
Date: |
Tue, 11 Mar 2014 12:36:55 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Kevin Wolf <address@hidden> wrote:
> After migration has completed, we call bdrv_invalidate_cache() so that
> drivers which cache some data drop their stale copy of the data and
> reread it from the image file to get a new version of data that the
> source modified while the migration was running.
>
> Reloading metadata from the image file is useless, though, if the size
> of the image file stays stale (this is a value that is cached for all
> image formats in block.c). Reads from (meta)data after the old EOF
> return only zeroes, causing image corruption.
>
> We need to update bs->total_sectors in all layers that could potentially
> have changed their size (i.e. backing files are not a concern - if they
> are changed, we're in bigger trouble)
>
> Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Tested-by: Juan Quintela <address@hidden>
I had problems with migration with qcow2 files, and this fixes it.