Re: [Qemu-devel] [PATCH RFC 0/2] qemu-arg: general purpose argument parser

[Leandro Dorileo]

Hi Andreas,


On Sun, Mar 09, 2014 at 05:32:17PM +0100, Andreas Färber wrote:
> Am 08.03.2014 19:47, schrieb Leandro Dorileo:
> > The following patchset introduces a general purpose argument parser and 
> > migrates
> > qemu-img to make use of it. qemu-img is just the first user of it, if we 
> > see a
> > good feedback here I move forward and migrate all the other possible users.
> 
> Why? :) You forgot to describe what's wrong with the current
> infrastructure, how your approach is different and what the benefit is.
>

Indead, I failed miserably on that (describing the problem intended to be 
solved).
The general sense is to unify the argument parsing strategies with some benefits
like help generation. If you see, every qemu binary has its own strategy - where
some (most?) use getopt and the QEMU main binary uses QemuOpt, they lack a 
runtine
help message generation, the sync between the help message and 
expected/implemented
arguments are done manually.

But I'm not sure if we really want/need it, that's the why I sent an early RFC. 
For
me it was just few weekend hours putting all together. :)

I see a good benefit on that - having a simple, clean, consistent and common API
throughout the source code. But again, do we want it? is it worth it?

Regards...

-- 
Leandro Dorileo