[Qemu-devel] [PATCH 5/7] monitor: Add set_link arguments completion.

[Hani Benhabiles]

This also adds the add_completion_option() function which is to be used for
other commands completions as well.

Signed-off-by: Hani Benhabiles <address@hidden>
---
 hmp-commands.hx |  1 +
 hmp.h           |  1 +
 monitor.c       | 45 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 47 insertions(+)

diff --git a/hmp-commands.hx b/hmp-commands.hx
index 813c0fb..fbd303a 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1332,6 +1332,7 @@ ETEXI
         .params     = "name on|off",
         .help       = "change the link status of a network adapter",
         .mhandler.cmd = hmp_set_link,
+        .command_completion = set_link_completion,
     },
 
 STEXI
diff --git a/hmp.h b/hmp.h
index 59a60ed..df19f1c 100644
--- a/hmp.h
+++ b/hmp.h
@@ -99,6 +99,7 @@ void object_del_completion(Monitor *mon, int nb_args, const 
char *str);
 void chardev_add_completion(Monitor *mon, int nb_args, const char *str);
 void chardev_remove_completion(Monitor *mon, int nb_args, const char *str);
 void cpu_completion(Monitor *mon, int nb_args, const char *str);
+void set_link_completion(Monitor *mon, int nb_args, const char *str);
 
 
 #endif
diff --git a/monitor.c b/monitor.c
index 43aab76..9905113 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4278,6 +4278,17 @@ static const char *next_arg_type(const char *typestr)
     return (p != NULL ? ++p : typestr);
 }
 
+static void add_completion_option(Monitor *mon, const char *str,
+                                  const char *option)
+{
+    if (!str || !option) {
+        return;
+    }
+    if (!strncmp(option, str, strlen(str))) {
+        readline_add_completion(mon->rs, option);
+    }
+}
+
 void chardev_add_completion(Monitor *mon, int nb_args, const char *str)
 {
     size_t len;
@@ -4453,6 +4464,40 @@ void cpu_completion(Monitor *mon, int nb_args, const 
char *str)
     qapi_free_CpuInfoList(start);
 }
 
+struct NicCompletionData {
+    Monitor *mon;
+    const char *str;
+};
+
+static void check_nic_completion(NICState *nic, void *data)
+{
+    Monitor *mon;
+    const char *str, *name;
+
+    mon = ((struct NicCompletionData *) data)->mon;
+    str = ((struct NicCompletionData *) data)->str;
+    name = nic->ncs->name;
+
+    if (!strncmp(name, str, strlen(str))) {
+        readline_add_completion(mon->rs, nic->ncs->name);
+    }
+}
+
+void set_link_completion(Monitor *mon, int nb_args, const char *str)
+{
+    readline_set_completion_index(mon->rs, strlen(str));
+    if (nb_args == 2) {
+        struct NicCompletionData data = {
+            .mon = mon,
+            .str = str,
+        };
+        qemu_foreach_nic(check_nic_completion, &data);
+    } else if (nb_args == 3) {
+        add_completion_option(mon, str, "on");
+        add_completion_option(mon, str, "off");
+    }
+}
+
 static void monitor_find_completion_by_table(Monitor *mon,
                                              const mon_cmd_t *cmd_table,
                                              char **args,
-- 
1.8.3.2