Re: [Qemu-devel] [PATCH v2 0/2] qdev-monitor-test: Simplify & make more robust

[Markus Armbruster]

Andreas Färber <address@hidden> writes:

> Am 06.03.2014 10:12, schrieb Markus Armbruster:
>> Stefan's patch has been rotting on the list since December.  Reposting
>> it together with a patch for a robustness issue I spotted when
>> reviewing it.
>
> Stefan had applied qdev-monitor-test through his block tree, and I was
> on vacation for most of December and would've needed a ping or two in
> the new year. qdev-monitor itself seems to be gray territory - I've been
> taking care of QOM conversion issues but otherwise don't feel
> responsible for the HMP/QMP interface and would expect the maintainer
> that does feel responsible to handle the matching test cases.

The test has a finger each in the block, QMP and qdev pie.  It could've
gone through any of these trees.  It got lost around Christmas.
Happens, no big deal :)

>> Markus Armbruster (1):
>>   qdev-monitor-test: Don't test human-readable error message
>> 
>> Stefan Hajnoczi (1):
>>   qdev-monitor-test: simplify using g_assert_cmpstr()
>> 
>>  tests/qdev-monitor-test.c | 8 +++-----
>>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> Thanks, applied to qom-next:
> https://github.com/afaerber/qemu-cpu/commits/qom-next

Thanks!