[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/2] Fix return value of vga initlization on ppc
From: |
Mark Wu |
Subject: |
[Qemu-devel] [PATCH v2 2/2] Fix return value of vga initlization on ppc |
Date: |
Fri, 7 Mar 2014 17:37:25 +0800 |
Before spapr_vga_init will returned false if the vga is specified by
the command '-device VGA' because vga_interface_type was evaluated to
VGA_NONE. With the change in previous patch of this series,
spapr_vga_init should return true if it's told that the vga will be
initialized in flow of the generic devices initialization.
This patch also makes two cleanups:
1. skip initialization for VGA_NONE
2. remove the useless 'break'
Signed-off-by: Mark Wu <address@hidden>
---
hw/ppc/spapr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 93d02c1..4d0ac56 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -765,13 +765,15 @@ static int spapr_vga_init(PCIBus *pci_bus)
{
switch (vga_interface_type) {
case VGA_NONE:
+ return false;
+ case VGA_DEVICE:
+ return true;
case VGA_STD:
return pci_vga_init(pci_bus) != NULL;
default:
fprintf(stderr, "This vga model is not supported,"
"currently it only supports -vga std\n");
exit(0);
- break;
}
}
--
1.8.4.2
- [Qemu-devel] [PATCH v2 1/2] Fix vga_interface_type for command '-device VGA', Mark Wu, 2014/03/07
- [Qemu-devel] [PATCH v2 2/2] Fix return value of vga initlization on ppc,
Mark Wu <=
- Re: [Qemu-devel] [PATCH v2 2/2] Fix return value of vga initlization on ppc, Paolo Bonzini, 2014/03/07
- Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] Fix return value of vga initlization on ppc, Alexey Kardashevskiy, 2014/03/08
- Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] Fix return value of vga initlization on ppc, Paolo Bonzini, 2014/03/09
- Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] Fix return value of vga initlization on ppc, Alexey Kardashevskiy, 2014/03/10
- Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] Fix return value of vga initlization on ppc, Paolo Bonzini, 2014/03/10
- Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] Fix return value of vga initlization on ppc, Alexey Kardashevskiy, 2014/03/10
- Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] Fix return value of vga initlization on ppc, Paolo Bonzini, 2014/03/10
- Re: [Qemu-devel] [PATCH v2 2/2] Fix return value of vga initlization on ppc, Mark Wu, 2014/03/10