[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: Always build with -fno-common

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] configure: Always build with -fno-common
Date: Thu, 6 Mar 2014 21:42:21 +0000

On 28 February 2014 17:19, Richard Henderson <address@hidden> wrote:
> On 02/26/2014 01:53 PM, Peter Maydell wrote:
>> In QEMU we don't make any use at all of the common symbol
>> functionality, so we can avoid this problem entirely simply
>> by compiling with -fno-common. Enable this option for all
>> builds, not just MacOSX, so that if we ever inadvertently
>> introduce multiple definitions of some variable that will
>> be immediately spotted as a build error rather than only
>> breaking the MacOSX build.
>> Suggested-by:  Markus Armbruster <address@hidden>
>> Signed-off-by: Peter Maydell <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>

Thanks. Applied to master as a MacOSX buildfix.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]