Re: [Qemu-devel] [PATCH qom-next v1 0/6] SSI QOM cleanups

[Andreas Färber]

Am 25.02.2014 09:51, schrieb Andreas Färber:
> Am 25.02.2014 09:46, schrieb Peter Crosthwaite:
>> Ping!
> 
> Looked good, didn't get to applying them yet. I did wonder though a) why
> 1/6 is not renaming the parent field to verify and b) whether I can swap
> d vs. dev naming in one hunk there while at it.

a) i) SSISlave::dev was still in use one more time - fixed and renamed
      with ..._FROM_QDEV() macro drop.
   ii) SSIBus::qbus was still in use one more time - fixed and renamed
       in situ.
b) Uniformly introduced DeviceState *dev for all affected initfns.

Thanks, applied them to qom-next with the above changes:
https://github.com/afaerber/qemu-cpu/commits/qom-next

Regards,
Andreas

>>> Peter Crosthwaite (6):
>>>   ssi: Convert legacy casts from SSI_SLAVE->DEVICE
>>>   ssi: Remove legacy SSI_BUS->BUS cast
>>>   misc: max111x: Create abstract max111x class
>>>   misc: max111x: QOM casting sweep
>>>   ssi: Remove SSI_SLAVE_FROM_QDEV macro
>>>   block/m25p80: Remove FROM_SSI_SLAVE usages
>>>
>>>  hw/arm/spitz.c       |  9 +++++----
>>>  hw/block/m25p80.c    |  6 +++---
>>>  hw/display/ads7846.c |  2 +-
>>>  hw/display/ssd0323.c |  4 ++--
>>>  hw/misc/max111x.c    | 46 +++++++++++++++++++++++++++++++++-------------
>>>  hw/sd/ssi-sd.c       |  2 +-
>>>  hw/ssi/ssi.c         |  4 ++--
>>>  include/hw/ssi.h     |  1 -
>>>  8 files changed, 47 insertions(+), 27 deletions(-)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg