[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2.1 02/28] NUMA: check if the total numa memory

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2.1 02/28] NUMA: check if the total numa memory size is equal to ram_size
Date: Tue, 04 Mar 2014 18:19:54 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

Il 04/03/2014 18:00, Eric Blake ha scritto:
On 03/04/2014 07:00 AM, Paolo Bonzini wrote:
From: Wanlong Gao <address@hidden>

If the total number of the assigned numa nodes memory is not
equal to the assigned ram size, it will write the wrong data
to ACPI talb, then the guest will ignore the wrong ACPI table


and recognize all memory to one node. It's buggy, we should
check it to ensure that we write the right data to ACPI table.

Signed-off-by: Wanlong Gao <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
 numa.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

+        if (numa_total != ram_size) {
+            fprintf(stderr, "qemu: numa nodes total memory size "
+                            "should equal to ram_size\n");

Is it worth also printing numa_total or ram_size values in this error

Good idea.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]