[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Discussion 04/10] memory_mapping: make this architectu
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [Discussion 04/10] memory_mapping: make this architecture-independent |
Date: |
Tue, 4 Mar 2014 11:05:38 +0000 |
On 4 March 2014 02:47, Xuebing Wang <address@hidden> wrote:
> Use vaddr (instead of target_ulong) for virtual address. See document HACKING
> for more information about vaddr and target_ulong.
>
> Signed-off-by: Xuebing Wang <address@hidden>
> ---
> include/sysemu/memory_mapping.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/sysemu/memory_mapping.h b/include/sysemu/memory_mapping.h
> index a75d59a..4a5f7be 100644
> --- a/include/sysemu/memory_mapping.h
> +++ b/include/sysemu/memory_mapping.h
> @@ -16,6 +16,7 @@
>
> #include "qemu/queue.h"
> #include "qemu/typedefs.h"
> +#include "qom/cpu.h" /* for vaddr */
>
> typedef struct GuestPhysBlock {
> /* visible to guest, reflects PCI hole, etc */
> @@ -39,7 +40,7 @@ typedef struct GuestPhysBlockList {
> /* The physical and virtual address in the memory mapping are contiguous. */
> typedef struct MemoryMapping {
> hwaddr phys_addr;
> - target_ulong virt_addr;
> + vaddr virt_addr;
> ram_addr_t length;
> QTAILQ_ENTRY(MemoryMapping) next;
> } MemoryMapping;
> --
> 1.7.9.5
If we're going to do this we should be consistent in this API:
at the moment most of the functions (private or otherwise)
in memory_mapping.c use "hwaddr" for virtual addresses.
It seems like a good idea, though.
thanks
-- PMM
- [Qemu-devel] [Discussion 01/10] docs: add docs/api-hierarchy.txt, (continued)
- [Qemu-devel] [Discussion 05/10] NEED_CPU_H: remove unnecessary inclusion of "cpu.h" in root, Xuebing Wang, 2014/03/03
- [Qemu-devel] [Discussion 03/10] NEED_CPU_H: remove unnecessary use of NEED_CPU_H, Xuebing Wang, 2014/03/03
- [Qemu-devel] [Discussion 04/10] memory_mapping: make this architecture-independent, Xuebing Wang, 2014/03/03
- [Qemu-devel] [Discussion 07/10] memory: remove file include/exec/address-spaces.h, Xuebing Wang, 2014/03/03
- [Qemu-devel] [Discussion 06/10] memory: move contents in include/exec/address-spaces.h => memory.h, Xuebing Wang, 2014/03/03
- [Qemu-devel] [Discussion 10/10] translate: remove file translate-all.h, Xuebing Wang, 2014/03/03
- [Qemu-devel] [Discussion 08/10] exec: move TranslationBlock API from exec-all.h => translate.h, Xuebing Wang, 2014/03/03
- [Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of "exec-all.h", Xuebing Wang, 2014/03/03