Re: [Qemu-devel] [PATCH] build: build block-obj-y explicitly before recursing

[Paolo Bonzini]

Il 28/02/2014 06:27, Stefan Weil ha scritto:
> > > >> -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y)
> > > >> +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(block-obj-y)
> Using SUBDIR_RULES here instead of SOFTMMU_SUBDIR_RULES (as in my patch)
> includes more dependencies: $(block-obj-y) will also be built for the
> user emulation code (i386-linux-user, ...) which does not need it. As
> far as I see, SOFTMMU_SUBDIR_RULES is sufficient.

True, it's just ugly to have all the dependencies in different parts of 
the Makefile.

If you fix it, can you move this line close to the existing

$(SOFTMMU_SUBDIR_RULES): config-all-devices.mak

We have too many knobs. :(

Paolo