[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 RESEND 0/4] qemu-img: add preallocation=full
From: |
Hu Tao |
Subject: |
Re: [Qemu-devel] [PATCH v5 RESEND 0/4] qemu-img: add preallocation=full |
Date: |
Fri, 28 Feb 2014 09:19:41 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Feb 27, 2014 at 03:09:57PM +0100, Stefan Hajnoczi wrote:
> On Tue, Feb 11, 2014 at 03:07:06PM +0800, Hu Tao wrote:
> > This series implements full image preallocation to create a non-sparse image
> > file at creation time, both for raw and qcow2 format. The purpose is to
> > avoid
> > performance deterioration of the guest cause by sparse image.
> >
> > v5:
> > - fix wrong calculation of qcow2 metadata size in v4
> > - remove raw_preallocate2()
> > - better error out path in raw_create()
> > - fix coding style
> >
> >
> > Hu Tao (4):
> > qapi: introduce PreallocMode and a new PreallocMode full.
> > raw, qcow2: don't convert file size to sector size
> > raw-posix: Add full image preallocation option
> > qcow2: Add full image preallocation option
> >
> > block/qcow2.c | 91
> > ++++++++++++++++++++++++++++++++++++++++++++++++-------
> > block/raw-posix.c | 45 +++++++++++++++++++++------
> > qapi-schema.json | 12 ++++++++
> > 3 files changed, 128 insertions(+), 20 deletions(-)
>
> Besides the comments that have been made, looks good. The metadata size
> calculation is correct now.
Thanks for review! I'll post v6 to address comments by Fam and Eric.
- Re: [Qemu-devel] [PATCH v5 RESEND 1/4] qapi: introduce PreallocMode and a new PreallocMode full., (continued)
- [Qemu-devel] [PATCH v5 RESEND 4/4] qcow2: Add full image preallocation option, Hu Tao, 2014/02/11
- [Qemu-devel] [PATCH v5 RESEND 3/4] raw-posix: Add full image preallocation option, Hu Tao, 2014/02/11
- [Qemu-devel] [PATCH v5 RESEND 2/4] raw, qcow2: don't convert file size to sector size, Hu Tao, 2014/02/11
- Re: [Qemu-devel] [PATCH v5 RESEND 0/4] qemu-img: add preallocation=full, Stefan Hajnoczi, 2014/02/27
- Re: [Qemu-devel] [PATCH v5 RESEND 0/4] qemu-img: add preallocation=full,
Hu Tao <=