Re: [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES Instructions

[Richard Henderson]

On 02/26/2014 02:06 PM, Tom Musta wrote:
> s/AES_Te4/AES_Te*/
> 
> And I should have added ...
> 
> Even though I cannot use AES_Te4, I certainly can construct a flattened table
> for InvMixColumns (a la AES_T*).  This will result in a faster implementation.
> 
> Does it make sense to put this InvMixColumns table in common utilities even
> if PowerPC is the only user?  It seems to be mainly an issue of space (about 
> 4K).
> 

Probably.

I think that ideally we'd generate the tables from the sboxes at build time,
rather than merely commenting them and pasting in the result.  Ideally, we'd
generate these tables into different source files, and thus into different
object files, and thus the object file would only get pulled in when used.

So ideally the issue of size would be a non-issue.


r~