[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/4] vfio: Fix overrun after readlink() fills buffer
From: |
Alex Williamson |
Subject: |
[Qemu-devel] [PULL 1/4] vfio: Fix overrun after readlink() fills buffer completely |
Date: |
Wed, 26 Feb 2014 11:25:55 -0700 |
User-agent: |
StGit/0.17-dirty |
From: Markus Armbruster <address@hidden>
readlink() returns the number of bytes written to the buffer, and it
doesn't write a terminating null byte. vfio_init() writes it itself.
Overruns the buffer when readlink() filled it completely.
Fix by treating readlink() filling the buffer completely as error,
like we do in pci-assign.c's assign_failed_examine().
Spotted by Coverity.
Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>
---
hw/misc/vfio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
index 8db182f..e669bbe 100644
--- a/hw/misc/vfio.c
+++ b/hw/misc/vfio.c
@@ -3681,10 +3681,10 @@ static int vfio_initfn(PCIDevice *pdev)
strncat(path, "iommu_group", sizeof(path) - strlen(path) - 1);
- len = readlink(path, iommu_group_path, PATH_MAX);
- if (len <= 0) {
+ len = readlink(path, iommu_group_path, sizeof(path));
+ if (len <= 0 || len >= sizeof(path)) {
error_report("vfio: error no iommu_group for device");
- return -errno;
+ return len < 0 ? -errno : ENAMETOOLONG;
}
iommu_group_path[len] = 0;
- [Qemu-devel] [PULL 0/4] vfio update and fix + pci-assign fix, Alex Williamson, 2014/02/26
- [Qemu-devel] [PULL 1/4] vfio: Fix overrun after readlink() fills buffer completely,
Alex Williamson <=
- [Qemu-devel] [PULL 2/4] pci-assign: Fix potential read beyond buffer on -EBUSY, Alex Williamson, 2014/02/26
- [Qemu-devel] [PULL 3/4] qdev-monitor: set DeviceState opts before calling realize, Alex Williamson, 2014/02/26
- [Qemu-devel] [PULL 4/4] vfio: blacklist loading of unstable roms, Alex Williamson, 2014/02/26
- Re: [Qemu-devel] [PULL 0/4] vfio update and fix + pci-assign fix, Alex Williamson, 2014/02/26
- Re: [Qemu-devel] [PULL 0/4] vfio update and fix + pci-assign fix, Peter Maydell, 2014/02/27