Re: [Qemu-devel] [PATCH 9/9] w32: Replace Windows specific data types in common header files

[Stefan Weil]

Am 25.02.2014 09:37, schrieb Andreas Färber:
> Am 25.02.2014 00:07, schrieb Stefan Weil:
[...]
>>> I had moved the field unchanged from another header, I believe. I don't
>>> think this is a good change (assuming the Windows API is still using
>>> this type and not void*), especially since it's #ifdef'ed anyway.
>> Please see my mail to Kevin (which will be sent in a moment).
> My opinion still stands. You can easily add "typedef void * HANDLE;" to
> qemu-typedefs.h or osdep.h to retain telling type names, in this case
> explaining why the variable is called "hThread" - h for "HANDLE".
>
> Regards,
> Andreas

I'm not sure whether I fully understand what you say.

Yes, adding a typedef for HANDLE or LONG is easy. I decided against that
solution because it is nearly impossible to avoid conflicts with the
typedefs pulled by windows.h. The QEMU typedef for HANDLE would have to
be protected by conditional compilation, and windows.h would have to be
included before that code. I am afraid that there will be lots of build
breakages in the future simply because people usually don't test with
MinGW and we have no simple rules how include statements should be ordered.

Stefan