[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] modules: do not include gmodule-2.0 in static b
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] modules: do not include gmodule-2.0 in static builds |
|
Date: |
Tue, 25 Feb 2014 16:42:29 +0000 |
On 25 February 2014 16:36, Paolo Bonzini <address@hidden> wrote:
> gmodule-2.0's pkg-config files include -Wl,--export-dynamic, which breaks
> static builds. It is a glib bug, but we need to support --static builds for
> the linux-user targets, and in the end all that is needed to fix this is:
>
> * outlaw --enable-modules --static, which makes little sense anyway
>
> * only include gmodule-2.0's cflags and ldflags if --enable-modules is
> specified on the command line.
>
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
This does indeed fix the problem; I'll apply it to master
later today since it's a build-fix.
thanks
-- PMM