qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] net: Disable netmap backend when not supported


From: Luigi Rizzo
Subject: Re: [Qemu-devel] [PATCH] net: Disable netmap backend when not supported
Date: Fri, 21 Feb 2014 20:44:53 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

On Thu, Feb 20, 2014 at 10:49:52AM +0100, Stefan Hajnoczi wrote:
> On Wed, Feb 19, 2014 at 04:57:28PM +0100, Vincenzo Maffione wrote:
...
> Please mention that in the commit description.
> 
> (I guess it's too late to give them a NETMAP_* prefix since defining D()
> and RD() in a system header has a fair chance of causing namespace
> conflicts.)

you are right that the naming is unfortunate and we will try
to address that at a later time, removing the macros.

As partial mitigation of the problem, they are intended only for
debugging (so they should only be used by lazy programmers;
applications should prefer application-specific logging functions),
and D(), RD() and ND() are only defined when 'NETMAP_WITH_LIBS' is
defined and this should happen only in the single file that implements
the netmap backend.

cheers
luigi



reply via email to

[Prev in Thread] Current Thread [Next in Thread]