Re: [Qemu-devel] [PULL 0/3] qtest: avoid pidfile and QEMU process leaks

[Peter Maydell]

On 19 February 2014 14:50, Stefan Hajnoczi <address@hidden> wrote:
> Reviewed by Paolo and Markus.  Here is the pull request.
>
> v2:
>  * Don't call qtest_end() from SIGABRT handler to avoid reentrancy [Paolo]
>  * Use sigemptyset() to avoid assumption about signal mask [Markus]
>  * if (fd != -1) close(fd) is no longer necessary [Markus]
>
> This series prevents the following qtest issues:
>
> 1. Leaking the pidfile if QEMU startup fails, as discovered by Andreas Färber.
> 2. Leaking the QEMU process when a test case aborts.
>
> Applying this series should make buildbots and manual "make check" users have 
> a
> more pleasant and less leaky experience :).
>
> The following changes since commit 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
>
>   Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/qtest-monitor-process-pull-request
>
> for you to fetch changes up to b15d422a23a3e4cf1b4195af209211eccdb88d51:
>
>   qtest: kill QEMU process on g_assert() failure (2014-02-19 15:45:51 +0100)

Applied, thanks.

-- PMM