Re: [Qemu-devel] [PATCH] tcg/i386: Fix build for systems without working cpuid.h (MacOSX, Win32)

[Brad Smith]

On 20/02/14 7:09 PM, Peter Maydell wrote:
> On 20 February 2014 23:55, Brad Smith <address@hidden> wrote:
> > On 20/02/14 12:50 PM, Peter Maydell wrote:
> > > Win32 doesn't have a cpuid.h, and MacOSX may have one but without
> > > the __cpuid() function we use, which means that commit 9d2eec20
> > > broke the build for those platforms. Fix this by tightening up
> > > our configure cpuid.h check to test that the functions we need
> > > are present, and adding some missing #ifdef guerds in
> > > tcg/i386/tcg-target.c.
> >
> >
> > The build will also fail if not using fairly new GCC
>
> Do you happen to know how new 'fairly new' is? My stock compile
> is with gcc 4.6.something, which isn't a spring chicken any more,
> and that worked OK.
>
> (We're going to fix this anyway, so it's just for my curiosity.)

Ok, it wasn't as new as I had thought. Actually taking a look at the
various releases __cpuid was added with GCC 4.3. __cpuid_count was
added with GCC 4.4.


--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.