[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] virtio-net: add a field to indicate if vlan
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] virtio-net: add a field to indicate if vlan table is used |
|
Date: |
Thu, 20 Feb 2014 09:47:59 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/20/2014 09:38 AM, Amos Kong wrote:
> Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't
> filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated.
>
> This patch added a new field to @RxFilterInfo to indicate if management
> uses the vlan table.
>
> [1] http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg02604.html
>
> Signed-off-by: Amos Kong <address@hidden>
> ---
> V2: don't make vlan-table optional, add a flag to indicate
> if vlan table is used by management
> +++ b/qapi-schema.json
> @@ -4032,6 +4032,8 @@
> #
> # @unicast-overflow: unicast table is overflowed or not
> #
> +# @vlan: whether management uses the vlan table
> +#
Needs a '(Since 2.0)' annotation.
If that gets fixed, you can add:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature