[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/20] Improve bdrv_open error messages
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/20] Improve bdrv_open error messages |
Date: |
Wed, 19 Feb 2014 15:06:16 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 17.02.2014 um 14:43 hat Paolo Bonzini geschrieben:
> Most of the block drivers are not using the Error** argument to bdrv_open,
> and instead just printing errors to stderr. This series improves that,
> and as a consequence it also avoids abuse of errno numbers.
>
> The only hurdle (caught by qemu-iotests, too) is VMDK, where we currently
> parse a file first as image, and second as a descriptor. This makes
> it hard to pick a good error message, because you do not know which
> attempt gave the most reasonable error message. For this reason patches
> 15-17 modify this approach and push up the detection of vmdk image file
> magic numbers.
>
> Apart from this, and from a segfault fixed by patch 7, the series consists
> of mostly trivial patches.
Thanks, applied to the block branch.
Kevin
- [Qemu-devel] [PATCH v3 19/20] block: do not abuse EMEDIUMTYPE, (continued)
- [Qemu-devel] [PATCH v3 19/20] block: do not abuse EMEDIUMTYPE, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 12/20] qed: correctly propagate errors, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 13/20] vhdx: correctly propagate errors, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 14/20] vvfat: correctly propagate errors, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 16/20] vmdk: push vmdk_read_desc up to caller, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 17/20] vmdk: do not try opening a file as both image and descriptor, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 18/20] vmdk: correctly propagate errors, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 20/20] vdi: say why an image is bad, Paolo Bonzini, 2014/02/17
- Re: [Qemu-devel] [PATCH v3 00/20] Improve bdrv_open error messages, Fam Zheng, 2014/02/18
- Re: [Qemu-devel] [PATCH v3 00/20] Improve bdrv_open error messages,
Kevin Wolf <=