Re: [Qemu-devel] [PATCH 2/3] util/crc32.c: Add CRC-32 implementation

[Peter Maydell]

On 17 February 2014 17:19, Will Newton <address@hidden> wrote:
> Add a table-driven CRC-32 implementation similar in style to the
> existing CRC-32C implementation.

> +++ b/include/qemu/crc32.h
> @@ -0,0 +1,15 @@
> +/*
> + *  CRC32C Checksum Algorithm
> + *
> + *  Polynomial: 0x04C11DB7
> + *
> + */
> +
> +#ifndef QEMU_CRC32_H
> +#define QEMU_CRC32_H
> +
> +#include "qemu-common.h"
> +
> +uint32_t crc32(uint32_t crc, const uint8_t *data, unsigned int length);

This seems like a bad idea because we have quite a bit
of code in QEMU which uses crc32() from zlib.h.

Is it possible to just use that implementation?

thanks
-- PMM