[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 06/22] cpu: Add per-cpu address space
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH v4 06/22] cpu: Add per-cpu address space |
Date: |
Fri, 14 Feb 2014 15:36:23 +1000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Feb 11, 2014 at 08:52:11PM +0100, Andreas Färber wrote:
> Edgar,
>
> Am 03.02.2014 10:44, schrieb Edgar E. Iglesias:
> > From: "Edgar E. Iglesias" <address@hidden>
> >
> > Signed-off-by: Edgar E. Iglesias <address@hidden>
> > ---
> > cpus.c | 2 ++
> > cputlb.c | 7 ++++---
> > exec.c | 27 +++++++++++++++++++--------
> > include/exec/exec-all.h | 1 +
> > include/exec/softmmu_template.h | 6 ++++--
> > include/qom/cpu.h | 3 +++
> > 6 files changed, 33 insertions(+), 13 deletions(-)
>
> This CPU patch did not get a Reviewed-by or Acked-by from me and was
> still committed, even without indicating so here! Had you asked me, you
> would've got one and my go-ahead, but what annoys me is that I learned
> about you committing this through it breaking my qom-cpu-13 branch with
> a conflict in target-i386/helper.c in later patch I had not yet
> reviewed... :/
>
> Please a) indicate you committed patches as an email reply to that
> series and b) read the replies - me, Peter and Paolo were converging on
> giving me the okay to take a subset of this series into qom-cpu, you
Sorry, I must have missed that part of the discussion. If the merge
conflict was bad let me know and I'd be happy to help.
Cheers,
Edgar
> neither asked nor did anyone propose committing them directly on the
> mailing list.
>
> Thanks,
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v4 00/22] Steps towards per CPU address-spaces, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 01/22] exec: Make tb_invalidate_phys_addr input an AS, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 02/22] exec: Make iotlb_to_region input an AS, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 03/22] exec: Always initialize MemorySection address spaces, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 04/22] exec: Make memory_region_section_get_iotlb use section AS, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 05/22] memory: Add MemoryListener to typedefs.h, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 06/22] cpu: Add per-cpu address space, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 07/22] exec: On AS changes, only flush affected CPU TLBs, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 08/22] exec: Make ldl_*_phys input an AddressSpace, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 09/22] exec: Make ldq/ldub_*_phys input an AddressSpace, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 10/22] exec: Make lduw_*_phys input an AddressSpace, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 11/22] exec: Make stq_*_phys input an AddressSpace, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 12/22] exec: Make stl_*_phys input an AddressSpace, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 13/22] exec: Make stl_phys_notdirty input an AddressSpace, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 14/22] exec: Make stw_*_phys input an AddressSpace, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 15/22] exec: Make stb_phys input an AddressSpace, Edgar E. Iglesias, 2014/02/03
- [Qemu-devel] [PATCH v4 17/22] exec: Make cpu_memory_rw_debug use the CPUs AS, Edgar E. Iglesias, 2014/02/03