[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 01/13] tests/qapi-schema: Actually check successf
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 01/13] tests/qapi-schema: Actually check successful QMP command response |
Date: |
Mon, 10 Feb 2014 15:20:33 +0100 |
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
tests/test-qmp-commands.c | 43 +++++++++++++++++++++++++++++++++++--------
1 file changed, 35 insertions(+), 8 deletions(-)
diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c
index 5a3e82a..d039b87 100644
--- a/tests/test-qmp-commands.c
+++ b/tests/test-qmp-commands.c
@@ -71,6 +71,23 @@ static void test_dispatch_cmd_error(void)
QDECREF(req);
}
+static QObject *test_qmp_dispatch(QDict *req)
+{
+ QObject *resp_obj;
+ QDict *resp;
+ QObject *ret;
+
+ resp_obj = qmp_dispatch(QOBJECT(req));
+ assert(resp_obj);
+ resp = qobject_to_qdict(resp_obj);
+ assert(resp && !qdict_haskey(resp, "error"));
+ ret = qdict_get(resp, "return");
+ assert(ret);
+ qobject_incref(ret);
+ qobject_decref(resp_obj);
+ return ret;
+}
+
/* test commands that involve both input parameters and return values */
static void test_dispatch_cmd_io(void)
{
@@ -78,7 +95,8 @@ static void test_dispatch_cmd_io(void)
QDict *args = qdict_new();
QDict *ud1a = qdict_new();
QDict *ud1b = qdict_new();
- QObject *resp;
+ QDict *ret, *ret_dict, *ret_dict_dict, *ret_dict_dict_userdef;
+ QDict *ret_dict_dict2, *ret_dict_dict2_userdef;
qdict_put_obj(ud1a, "integer", QOBJECT(qint_from_int(42)));
qdict_put_obj(ud1a, "string", QOBJECT(qstring_from_str("hello")));
@@ -87,15 +105,24 @@ static void test_dispatch_cmd_io(void)
qdict_put_obj(args, "ud1a", QOBJECT(ud1a));
qdict_put_obj(args, "ud1b", QOBJECT(ud1b));
qdict_put_obj(req, "arguments", QOBJECT(args));
-
qdict_put_obj(req, "execute", QOBJECT(qstring_from_str("user_def_cmd2")));
- /* TODO: put in full payload and check for errors */
- resp = qmp_dispatch(QOBJECT(req));
- assert(resp != NULL);
- assert(!qdict_haskey(qobject_to_qdict(resp), "error"));
-
- qobject_decref(resp);
+ ret = qobject_to_qdict(test_qmp_dispatch(req));
+
+ assert(!strcmp(qdict_get_str(ret, "string"), "blah1"));
+ ret_dict = qdict_get_qdict(ret, "dict");
+ assert(!strcmp(qdict_get_str(ret_dict, "string"), "blah2"));
+ ret_dict_dict = qdict_get_qdict(ret_dict, "dict");
+ ret_dict_dict_userdef = qdict_get_qdict(ret_dict_dict, "userdef");
+ assert(qdict_get_int(ret_dict_dict_userdef, "integer") == 42);
+ assert(!strcmp(qdict_get_str(ret_dict_dict_userdef, "string"), "hello"));
+ assert(!strcmp(qdict_get_str(ret_dict_dict, "string"), "blah3"));
+ ret_dict_dict2 = qdict_get_qdict(ret_dict, "dict2");
+ ret_dict_dict2_userdef = qdict_get_qdict(ret_dict_dict2, "userdef");
+ assert(qdict_get_int(ret_dict_dict2_userdef, "integer") == 422);
+ assert(!strcmp(qdict_get_str(ret_dict_dict2_userdef, "string"), "hello2"));
+ assert(!strcmp(qdict_get_str(ret_dict_dict2, "string"), "blah4"));
+ QDECREF(ret);
QDECREF(req);
}
--
1.8.1.4
- [Qemu-devel] [PATCH v2 00/13] qapi: Test coverage & clean up generated code, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 08/13] qapi: Fix licensing of scripts, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 10/13] qapi: Drop unused code in qapi-commands.py, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 02/13] tests/qapi-schema: Cover optional command arguments, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 06/13] tests/qapi-schema: Cover union types with base, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 05/13] tests/qapi-schema: Cover complex types with base, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 07/13] tests/qapi-schema: Cover flat union types, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 01/13] tests/qapi-schema: Actually check successful QMP command response,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 03/13] tests/qapi-schema: Cover simple argument types, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 11/13] qapi: Clean up null checking in generated visitors, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct(), Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 04/13] tests/qapi-schema: Cover anonymous union types, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str(), Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 09/13] qapi: Drop nonsensical header guard in generated qapi-visit.c, Markus Armbruster, 2014/02/10
- Re: [Qemu-devel] [PATCH v2 00/13] qapi: Test coverage & clean up generated code, Paolo Bonzini, 2014/02/13