Re: [Qemu-devel] [PATCH qom-next v2 02/12] tests: Add vmxnet3 qtest

[Dmitry Fleytman]

On Feb 9, 2014, at 13:57 PM, Andreas Färber <address@hidden> wrote:

> Note that this will emit a warning:
> [vmxnet3][WR][vmxnet3_peer_has_vnet_hdr]: Peer has no virtio extension.
> Task offloads will be emulated.
> 
> Cc: Dmitry Fleytman <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> tests/Makefile       |  5 +++++
> tests/vmxnet3-test.c | 33 +++++++++++++++++++++++++++++++++
> 2 files changed, 38 insertions(+)
> create mode 100644 tests/vmxnet3-test.c

Reviewed-by: Dmitry Fleytman <address@hidden>

> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 57e21fc..323c600 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -83,6 +83,10 @@ check-qtest-i386-y += tests/blockdev-test$(EXESUF)
> check-qtest-i386-y += tests/qdev-monitor-test$(EXESUF)
> check-qtest-i386-y += $(check-qtest-pci-y)
> gcov-files-i386-y += $(gcov-files-pci-y)
> +check-qtest-i386-y += tests/vmxnet3-test$(EXESUF)
> +gcov-files-i386-y += hw/net/vmxnet3.c
> +gcov-files-i386-y += hw/net/vmxnet_rx_pkt.c
> +gcov-files-i386-y += hw/net/vmxnet_tx_pkt.c
> check-qtest-x86_64-y = $(check-qtest-i386-y)
> gcov-files-i386-y += i386-softmmu/hw/mc146818rtc.c
> gcov-files-x86_64-y = $(subst 
> i386-softmmu/,x86_64-softmmu/,$(gcov-files-i386-y))
> @@ -203,6 +207,7 @@ tests/tmp105-test$(EXESUF): tests/tmp105-test.o 
> $(libqos-omap-obj-y)
> tests/i440fx-test$(EXESUF): tests/i440fx-test.o $(libqos-pc-obj-y)
> tests/fw_cfg-test$(EXESUF): tests/fw_cfg-test.o $(libqos-pc-obj-y)
> tests/e1000-test$(EXESUF): tests/e1000-test.o
> +tests/vmxnet3-test$(EXESUF): tests/vmxnet3-test.o
> tests/qom-test$(EXESUF): tests/qom-test.o
> tests/blockdev-test$(EXESUF): tests/blockdev-test.o $(libqos-pc-obj-y)
> tests/qdev-monitor-test$(EXESUF): tests/qdev-monitor-test.o $(libqos-pc-obj-y)
> diff --git a/tests/vmxnet3-test.c b/tests/vmxnet3-test.c
> new file mode 100644
> index 0000000..a2ebed3
> --- /dev/null
> +++ b/tests/vmxnet3-test.c
> @@ -0,0 +1,33 @@
> +/*
> + * QTest testcase for vmxnet3 NIC
> + *
> + * Copyright (c) 2013-2014 SUSE LINUX Products GmbH
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +
> +#include <glib.h>
> +#include <string.h>
> +#include "libqtest.h"
> +#include "qemu/osdep.h"
> +
> +/* Tests only initialization so far. TODO: Replace with functional tests */
> +static void nop(void)
> +{
> +}
> +
> +int main(int argc, char **argv)
> +{
> +    int ret;
> +
> +    g_test_init(&argc, &argv, NULL);
> +    qtest_add_func("/vmxnet3/nop", nop);
> +
> +    qtest_start("-device vmxnet3");
> +    ret = g_test_run();
> +
> +    qtest_end();
> +
> +    return ret;
> +}
> -- 
> 1.8.4.5
>