[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/11] z2: QOM'ify AER915
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/11] z2: QOM'ify AER915 |
|
Date: |
Sun, 09 Feb 2014 14:04:15 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 09.02.2014 02:38, schrieb Peter Crosthwaite:
> On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber <address@hidden> wrote:
>> Replace usages of FROM_I2C_SLAVE() with QOM cast macro.
>>
>> Signed-off-by: Andreas Färber <address@hidden>
>
> Reviewed-by: Peter Crosthwaite <address@hidden>
Thanks, adding and mentioning the following on top:
diff --git a/hw/arm/z2.c b/hw/arm/z2.c
index 69c4d38..67c1be8 100644
--- a/hw/arm/z2.c
+++ b/hw/arm/z2.c
@@ -357,7 +357,7 @@ static void z2_init(QEMUMachineInitArgs *args)
type_register_static(&aer915_info);
z2_lcd = ssi_create_slave(mpu->ssp[1], "zipit-lcd");
bus = pxa2xx_i2c_bus(mpu->i2c[0]);
- i2c_create_slave(bus, "aer915", 0x55);
+ i2c_create_slave(bus, TYPE_AER915, 0x55);
wm = i2c_create_slave(bus, "wm8750", 0x1b);
mpu->i2s->opaque = wm;
mpu->i2s->codec_out = wm8750_dac_dat;
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg