[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/14] qdev: legacy properties are just strings
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 05/14] qdev: legacy properties are just strings |
Date: |
Sat, 8 Feb 2014 11:01:48 +0100 |
prop->info->legacy_name is still used by "-device foo,?".
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/core/qdev.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 7c1b732..482a978 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -590,7 +590,7 @@ static void qdev_get_legacy_property(Object *obj, Visitor
*v, void *opaque,
void qdev_property_add_legacy(DeviceState *dev, Property *prop,
Error **errp)
{
- gchar *name, *type;
+ gchar *name;
/* Register pointer properties as legacy properties */
if (!prop->info->print && prop->info->get) {
@@ -598,16 +598,12 @@ void qdev_property_add_legacy(DeviceState *dev, Property
*prop,
}
name = g_strdup_printf("legacy-%s", prop->name);
- type = g_strdup_printf("legacy<%s>",
- prop->info->legacy_name ?: prop->info->name);
-
- object_property_add(OBJECT(dev), name, type,
+ object_property_add(OBJECT(dev), name, "str",
prop->info->print ? qdev_get_legacy_property :
prop->info->get,
NULL,
NULL,
prop, errp);
- g_free(type);
g_free(name);
}
--
1.8.5.3
- [Qemu-devel] [PULL 00/14] Cleanup qdev legacy properties, Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 01/14] qapi: add size parser to StringInputVisitor, Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 02/14] qdev: sizes are now parsed by StringInputVisitor, Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 03/14] qdev: remove legacy parsers for hex8/32/64, Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 04/14] qdev: legacy properties are now read-only, Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 05/14] qdev: legacy properties are just strings,
Paolo Bonzini <=
- [Qemu-devel] [PULL 06/14] qdev: inline qdev_prop_parse, Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 08/14] qdev: use human mode in "info qtree", Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 09/14] qdev: remove most legacy printers, Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 10/14] qdev: remove hex8/32/64 property types, Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 11/14] block: handle "rechs" and "large" translation options, Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 12/14] qdev: add enum property types to QAPI schema, Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 13/14] qdev: use QAPI type names for properties, Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 14/14] qapi: refine human printing of sizes, Paolo Bonzini, 2014/02/08
- [Qemu-devel] [PULL 07/14] qapi: add human mode to StringOutputVisitor, Paolo Bonzini, 2014/02/08
- Re: [Qemu-devel] [PULL 00/14] Cleanup qdev legacy properties, Andreas Färber, 2014/02/08