Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support

[Paolo Bonzini]

Il 07/02/2014 09:14, Michael Tokarev ha scritto:
> 07.02.2014 11:13, Paolo Bonzini wrote:
> > > Il 07/02/2014 01:06, Peter Maydell ha scritto:
> > > >> Why do we need OS specific code to do this when the code
> > > >> in vl.c for getting the executable path to use as a base for
> > > >> finding bios blobs works fine without OS specific code?
> > >
> > > That's because right now module_call_init is not receiving an argv[0] to pass 
> > to qemu_exec_dir (os_find_datadir has an argument for that).  It can be fixed (in 
> > the whole call chain, including e.g. bdrv_init/bdrv_init_with_whitelist).
>
> We can add a global variable (either executable_dir or whole -L path),
> init it in vl.c as we do now, and use it in other places in a uniform
> way.

FWIW there's not just vl.c, there's also qemu-io.c and qemu-img.c.  In 
the future tests could also need to do the same.

> BTW, It'd be really good to have a separate, arch-specific directory for
> the plugins, like /usr/lib/x86_64-linux-gnu/qemu/, so it will be
> multiarch-able.  But it is not really a show-stopper.

Why isn't it enough to do --libdir=/usr/lib/x86_64-linux-gnu?

Paolo