[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v5 03/12] milkymist-uart: use qemu_chr_fe_write_all()
From: |
Michael Walle |
Subject: |
[Qemu-devel] [PULL v5 03/12] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() |
Date: |
Tue, 4 Feb 2014 19:58:25 +0100 |
From: Antony Pavlov <address@hidden>
qemu_chr_fe_write() is capable of returning 0
to indicate EAGAIN (and friends) and we don't
handle this.
Just change it to qemu_chr_fe_write_all() to fix.
Reported-by: Peter Crosthwaite <address@hidden>
Acked-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Antony Pavlov <address@hidden>
Signed-off-by: Michael Walle <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
hw/char/milkymist-uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c
index 2c52a0f..da51f82 100644
--- a/hw/char/milkymist-uart.c
+++ b/hw/char/milkymist-uart.c
@@ -124,7 +124,7 @@ static void uart_write(void *opaque, hwaddr addr, uint64_t
value,
switch (addr) {
case R_RXTX:
if (s->chr) {
- qemu_chr_fe_write(s->chr, &ch, 1);
+ qemu_chr_fe_write_all(s->chr, &ch, 1);
}
s->regs[R_STAT] |= STAT_TX_EVT;
break;
--
1.7.10.4
- [Qemu-devel] [PULL v5 00/12] target-lm32 updates, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 03/12] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write(),
Michael Walle <=
- [Qemu-devel] [PULL v5 02/12] tests: lm32: new rule for single test cases, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 12/12] hw/lm32: print error if cpu model is not found, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 06/12] target-lm32: kill cpu_abort() calls, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 04/12] lm32_uart/lm32_juart: use qemu_chr_fe_write_all(), Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 09/12] lm32_sys: print test result on stderr, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 11/12] target-lm32: stop VM on illegal or unknown instruction, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 08/12] target-lm32: add breakpoint/watchpoint support, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 05/12] milkymist-vgafb: swap pixel data in source buffer, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 10/12] lm32_sys: dump cpu state if test case fails, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 01/12] lm32_sys: increase test case name length limit, Michael Walle, 2014/02/04