[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qmp: expose list of supported character devi
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2] qmp: expose list of supported character device backends |
Date: |
Fri, 31 Jan 2014 10:20:42 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/31/2014 09:49 AM, Martin Kletzander wrote:
> Introduce 'query-chardev-backends' QMP command which lists all
> supported character device backends.
>
> Signed-off-by: Martin Kletzander <address@hidden>
> ---
> v2:
> - Version changed from "1.8.0" to "2.0"
>
> qapi-schema.json | 22 ++++++++++++++++++++++
> qemu-char.c | 19 +++++++++++++++++++
> qmp-commands.hx | 41 +++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 82 insertions(+)
> +
> +-> { "execute": "query-chardev-backends" }
> +<- {
> + "return":[
> + {
> + "name":"udp",
> + },
Sorry for not noticing earlier, but this is not valid JSON. Lose the
trailing comma after each "name":"value", since the last element in a
JSON struct is not permitted to have a comma.
> + {
> + "name":"tcp",
> + },
> + {
> + "name":"unix",
> + },
> + {
> + "name":"spiceport",
> + }
With that change to all four spots,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature