Re: [Qemu-devel] [PATCH 15/21] target-arm: A64: Add SIMD simple 64 bit insns from scalar 2-reg misc

[Richard Henderson]

On 01/26/2014 11:25 AM, Peter Maydell wrote:
> +    do_cmop:
> +        tcg_gen_setcondi_i64(tcg_invert_cond(cond), tcg_rd, tcg_rn, 0);
> +        tcg_gen_subi_i64(tcg_rd, tcg_rd, 1);
> +        break;

Another instance of (!test - 1) instead of -(test).

Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~