qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/5 v2] Provide common methods for exchange FD


From: Antonios Motakis
Subject: Re: [Qemu-devel] [PATCH 0/5 v2] Provide common methods for exchange FD
Date: Thu, 23 Jan 2014 19:55:40 +0100

Hello,


On Thu, Jan 23, 2014 at 9:27 AM, Lei Li <address@hidden> wrote:
This patch series tries to refactor the functions used for
exchange of FD in current code, provide common methods
for it.

I just tested it through page flipping migration, and tap/
bridge-helper a bit, but have some environment problem on
proxy fs driver. So it'd be appreciated if someone could
help on verifying whether it has impact on it. :)

Please let me know if there is anything needs to be improved.

Thanks


This looks really interesting. We are currently working on a patch series that will also need to exchange file descriptors(see vhost_user_send_fds in http://lists.gnu.org/archive/html/qemu-devel/2014-01/msg01444.html).

I wonder if you have taken into account the case of sending multiple file descriptors in one go.

Antonios
 

Changes since V1:
  -- Copy right and typo fixes pointed out by Eric.
  -- Don't cast 'char *' to 'int *' from Daniel.
  -- Get rid of local migration part.

Lei Li (5):
  fd-exchange: provide common methods for exchange of fd
  qemu-bridge-helper: replace send_fd with qemu_send_with_fd
  net/tap: replace recv_fd with qemu_recv_with_fd
  virtfs-proxy-helper: replace send_fd with qemu_send_with_fd
  virtio-9p-proxy: replace v9fs_receivefd with qemu_recv_with_fd

 Makefile                    |    2 +-
 fsdev/virtfs-proxy-helper.c |   51 ++++-------------------
 hw/9pfs/virtio-9p-proxy.c   |   60 +-------------------------
 hw/9pfs/virtio-9p-proxy.h   |    5 --
 include/qemu/fd-exchange.h  |   25 +++++++++++
 net/tap.c                   |   40 +----------------
 qemu-bridge-helper.c        |   31 +------------
 util/Makefile.objs          |    1 +
 util/qemu-fd-exchange.c     |   97 +++++++++++++++++++++++++++++++++++++++++++
 10 files changed, 144 insertions(+), 220 deletions(-)
 create mode 100644 include/qemu/fd-exchange.h
 create mode 100644 util/qemu-fd-exchange.c




reply via email to

[Prev in Thread] Current Thread [Next in Thread]