[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] block: update block commit documentation
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] block: update block commit documentation regarding image truncation |
Date: |
Tue, 21 Jan 2014 09:37:11 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/21/2014 09:31 AM, Jeff Cody wrote:
> This updates the documentation for commiting snapshot images.
> Specifically, this highlights what happens when the base image
> is either smaller or larger than the snapshot image being committed.
>
> In the case of the base image being smaller, it is resized to the
> larger size of the snapshot image. In the case of the base image
> being larger, it is not resized automatically, but once the commit
> has completed it is safe for the user to truncate the base image.
>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -1973,6 +1973,13 @@
> # user needs to complete the job with the
> block-job-complete
> # command after getting the ready event. (Since 2.0)
> #
> +# If the base image is smaller than top, then the base
> image
> +# will be resized to be the same size as top. If top is
> +# smaller than the base image, the base will not be
Spurious double space.
> +SQMP
> +block-commit
> +------------
> +
> +
> + If the base image is smaller than top, then the base image
> + will be resized to be the same size as top. If top is
> + smaller than the base image, the base will not be
and again.
But as that is minor,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature