[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 13/29] block: Introduce bdrv_co_do_pwritev()
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH v3 13/29] block: Introduce bdrv_co_do_pwritev() |
Date: |
Tue, 21 Jan 2014 14:36:27 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Le Friday 17 Jan 2014 à 15:15:03 (+0100), Kevin Wolf a écrit :
> This is going to become the bdrv_co_do_preadv() equivalent for writes.
> In this patch, however, just a function taking byte offsets is created,
> it doesn't align anything yet.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 24 ++++++++++++++++++------
> 1 file changed, 18 insertions(+), 6 deletions(-)
>
> diff --git a/block.c b/block.c
> index fe55217..328f592 100644
> --- a/block.c
> +++ b/block.c
> @@ -3016,8 +3016,8 @@ static int coroutine_fn
> bdrv_aligned_pwritev(BlockDriverState *bs,
> /*
> * Handle a write request in coroutine context
> */
> -static int coroutine_fn bdrv_co_do_writev(BlockDriverState *bs,
> - int64_t sector_num, int nb_sectors, QEMUIOVector *qiov,
> +static int coroutine_fn bdrv_co_do_pwritev(BlockDriverState *bs,
> + int64_t offset, unsigned int bytes, QEMUIOVector *qiov,
> BdrvRequestFlags flags)
> {
> int ret;
> @@ -3028,21 +3028,33 @@ static int coroutine_fn
> bdrv_co_do_writev(BlockDriverState *bs,
> if (bs->read_only) {
> return -EACCES;
> }
> - if (bdrv_check_request(bs, sector_num, nb_sectors)) {
> + if (bdrv_check_byte_request(bs, offset, bytes)) {
> return -EIO;
> }
>
> /* throttling disk I/O */
> if (bs->io_limits_enabled) {
> - bdrv_io_limits_intercept(bs, nb_sectors, true);
> + /* TODO Switch to byte granularity */
> + bdrv_io_limits_intercept(bs, bytes >> BDRV_SECTOR_BITS, true);
> }
>
> - ret = bdrv_aligned_pwritev(bs, sector_num << BDRV_SECTOR_BITS,
> - nb_sectors << BDRV_SECTOR_BITS, qiov, flags);
> + ret = bdrv_aligned_pwritev(bs, offset, bytes, qiov, flags);
>
> return ret;
> }
>
> +static int coroutine_fn bdrv_co_do_writev(BlockDriverState *bs,
> + int64_t sector_num, int nb_sectors, QEMUIOVector *qiov,
> + BdrvRequestFlags flags)
> +{
> + if (nb_sectors < 0 || nb_sectors > (INT_MAX >> BDRV_SECTOR_BITS)) {
> + return -EINVAL;
> + }
> +
> + return bdrv_co_do_pwritev(bs, sector_num << BDRV_SECTOR_BITS,
> + nb_sectors << BDRV_SECTOR_BITS, qiov, flags);
> +}
> +
> int coroutine_fn bdrv_co_writev(BlockDriverState *bs, int64_t sector_num,
> int nb_sectors, QEMUIOVector *qiov)
> {
> --
> 1.8.1.4
>
>
Reviewed-by: Benoit Canet <address@hidden>
- Re: [Qemu-devel] [PATCH v3 10/29] block: Introduce bdrv_co_do_preadv(), (continued)
- [Qemu-devel] [PATCH v3 07/29] block: rename buffer_alignment to guest_block_size, Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 11/29] block: Introduce bdrv_aligned_pwritev(), Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 12/29] block: write: Handle COR dependency after I/O throttling, Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 13/29] block: Introduce bdrv_co_do_pwritev(), Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 16/29] block: Make zero-after-EOF work with larger alignment, Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 14/29] block: Switch BdrvTrackedRequest to byte granularity, Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 15/29] block: Allow waiting for overlapping requests between begin/end, Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 17/29] block: Generalise and optimise COR serialisation, Kevin Wolf, 2014/01/17