[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] hw/display/qxl: fix signed to unsigned compa
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v4] hw/display/qxl: fix signed to unsigned comparison |
Date: |
Tue, 21 Jan 2014 11:55:35 +0100 |
On Mo, 2014-01-20 at 18:57 +0200, Alon Levy wrote:
> Several small signedness / overflow corrections to
> qxl_create_guest_primary:
> 1. use 64 bit unsigned for size to avoid overflow possible from two 32
> bit multiplicants.
> 2. correct sign for requested_height
> 3. add a more verbose error message when setting guest bug state
> (which
> causes a complete guess blackout until reset, so it helps if it is
> verbose).
Added to spice patch queue.
thanks,
Gerd