Re: [Qemu-devel] [V7 PATCH 18/18] target-ppc: Scalar Non-Signalling Conversions

[Richard Henderson]

On 01/15/2014 06:10 AM, Tom Musta wrote:
> This patch adds the non-signalling scalar conversion instructions:
> 
>   - VSX Scalar Convert Single Precision to Double Precision
>     Non-Signalling (xscvspdpn)
>   - VSX Scalar Convert Double Precision to Single Precision
>     Non-Signalling (xscvdpspn)
> 
> Signed-off-by: Tom Musta <address@hidden>
> ---
> V6: New.
> 
> V7: Adjusted helper signatures per Richard Henderson's review.

Reviewed-by: Richard Henderson <address@hidden>

> +DEF_HELPER_2(xscvdpspn, i64, env, i64)
>  DEF_HELPER_2(xscvspdp, void, env, i32)
> +DEF_HELPER_2(xscvspdpn, i64, env, i64)

Something else for future cleanup, along with changing any other vsx scalar
operation according to this by-value sort of signature is to add proper helper
flags.  Since these neither raise exceptions nor set fp status bits, use

DEF_HELPER_FLAGS_2(xscvdpspn, TCG_CALL_NO_RWG_SE, i64, env, i64)


r~