[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=o
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=on to be used together |
|
Date: |
Tue, 14 Jan 2014 12:30:05 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/14/2014 12:12 PM, Jeff Cody wrote:
> Having both read-only=on and snapshot=on together does not make sense;
> currently, the read-only argument is effectively ignored for the
> temporary snapshot. To prevent confusion, disallow the usage of both
> 'snapshot=on' and 'read-only=on'.
>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> blockdev.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
No impact to libvirt, which (intentionally) doesn't use snapshot=on.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature