Re: [Qemu-devel] [PATCH 1/1] KVM: Retry KVM_CREATE_VM on EINTR or EAGAIN

[Paolo Bonzini]

Il 10/01/2014 23:15, Tom Knych ha scritto:
> I'll flip the conditional check
> 
> So I traced thru the code and the one path I saw returning EINTR was:
> 
> kvm_dev_ioctl_create_vm -> kvm_create_vm -> kvm_init_mmu_notifier ->
> mmu_notifier_register ->  do_mmu_notifier_register -> mm_take_all_locks
> 
> Which checks if any signals have been raised while it was attaining
> locks and returns EINTR.
> 
> Going thru my logs - all of my errors actually are EINTRs I'll remove
> the EAGAIN

Andrea, what do you think here?  Is it intended that
kvm_init_mmu_notifier return an EINTR that percolates up to userspace?

Paolo