[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC v2 4/6] qdev: add get_pointer_and_free() for temporary
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [RFC v2 4/6] qdev: add get_pointer_and_free() for temporary strings |
Date: |
Fri, 10 Jan 2014 09:45:14 +0800 |
get_pointer() assumes the string has unspecified lifetime (at least as
long as the object is alive). In some cases we can only produce a
temporary string that should be freed when get_pointer() is done.
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/core/qdev-properties-system.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index 729efa8..200f853 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -31,6 +31,20 @@ static void get_pointer(Object *obj, Visitor *v, Property
*prop,
visit_type_str(v, &p, name, errp);
}
+/* Same as get_pointer() but frees heap-allocated print() return value */
+static void get_pointer_and_free(Object *obj, Visitor *v, Property *prop,
+ char *(*print)(void *ptr),
+ const char *name, Error **errp)
+{
+ DeviceState *dev = DEVICE(obj);
+ void **ptr = qdev_get_prop_ptr(dev, prop);
+ char *p;
+
+ p = *ptr ? print(*ptr) : g_strdup("");
+ visit_type_str(v, &p, name, errp);
+ g_free(p);
+}
+
static void set_pointer(Object *obj, Visitor *v, Property *prop,
int (*parse)(DeviceState *dev, const char *str,
void **ptr),
--
1.8.4.2
- [Qemu-devel] [RFC v2 0/6] dataplane: switch to N:M devices-per-thread model, Stefan Hajnoczi, 2014/01/09
- [Qemu-devel] [RFC v2 1/6] rfifolock: add recursive FIFO lock, Stefan Hajnoczi, 2014/01/09
- [Qemu-devel] [RFC v2 2/6] aio: add aio_context_acquire() and aio_context_release(), Stefan Hajnoczi, 2014/01/09
- [Qemu-devel] [RFC v2 3/6] iothread: add I/O thread object, Stefan Hajnoczi, 2014/01/09
- [Qemu-devel] [RFC v2 4/6] qdev: add get_pointer_and_free() for temporary strings,
Stefan Hajnoczi <=
- [Qemu-devel] [RFC v2 5/6] iothread: add "iothread" qdev property type, Stefan Hajnoczi, 2014/01/09
- [Qemu-devel] [RFC v2 6/6] dataplane: replace internal thread with IOThread, Stefan Hajnoczi, 2014/01/09