[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculati
From: |
Wenchao Xia |
Subject: |
Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed |
Date: |
Thu, 09 Jan 2014 16:29:36 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
δΊ 2014/1/8 17:08, Peter Lieven ει:
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> ui/vnc.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index da552fe..a742d32 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3170,7 +3170,9 @@ void vnc_display_open(DisplayState *ds, const char
> *display, Error **errp)
> acl = 1;
> #endif
> } else if (strncmp(options, "lossy", 5) == 0) {
> +#ifdef CONFIG_VNC_JPEG
> vs->lossy = true;
> +#endif
> } else if (strncmp(options, "non-adaptive", 12) == 0) {
> vs->non_adaptive = true;
> } else if (strncmp(options, "share=", 6) == 0) {
> @@ -3187,6 +3189,13 @@ void vnc_display_open(DisplayState *ds, const char
> *display, Error **errp)
> }
> }
>
> + /* adaptive updates are only used with tight encoding and
> + * if lossy updates are enabled so we can disable all the
> + * calculations otherwise */
> + if (!vs->lossy) {
> + vs->non_adaptive = true;
> + }
> +
The code seems: if vs->loosy == false, then vs->non_adaptive = true,
translate as: if loosy update is not used, then don't do adaptive
update., which doesn't conform with the comments. I am not sure if this
is on expectation.
> #ifdef CONFIG_VNC_TLS
> if (acl && x509 && vs->tls.x509verify) {
> if (!(vs->tls.acl = qemu_acl_init("vnc.x509dname"))) {
>
- [Qemu-devel] [PATCHv4 0/6] ui/vnc: update optimizations, Peter Lieven, 2014/01/08
- [Qemu-devel] [PATCHv4 4/6] ui/vnc: optimize clearing in find_and_clear_dirty_height(), Peter Lieven, 2014/01/08
- [Qemu-devel] [PATCHv4 1/6] ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro, Peter Lieven, 2014/01/08
- [Qemu-devel] [PATCHv4 2/6] ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT, Peter Lieven, 2014/01/08
- [Qemu-devel] [PATCHv4 3/6] ui/vnc: optimize dirty bitmap tracking, Peter Lieven, 2014/01/08
- [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed, Peter Lieven, 2014/01/08
- Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed,
Wenchao Xia <=
- Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed, Peter Lieven, 2014/01/09
- Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed, Wenchao Xia, 2014/01/09
- Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed, Peter Lieven, 2014/01/10
- Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed, Wenchao Xia, 2014/01/12
- Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed, Peter Lieven, 2014/01/13
[Qemu-devel] [PATCHv4 5/6] ui/vnc: optimize setting in vnc_dpy_update(), Peter Lieven, 2014/01/08
Re: [Qemu-devel] [PATCHv4 0/6] ui/vnc: update optimizations, Peter Lieven, 2014/01/20