Re: [Qemu-devel] [PATCH v7 00/24] blkdebug/blkverify: Allow QMP configuration

[Kevin Wolf]

Am 20.12.2013 um 19:28 hat Max Reitz geschrieben:
> Currently, the configuration of blkdebug and blkverify is done through
> the "filename" alone. There is now way of manually choosing blkdebug or
> blkverify as a driver and using a normal image filename.
> 
> In the case of blkdebug, the filename starts with the protocol prefix,
> follows up with the name of a configuration file and ends with the name
> of the image file.
> 
> In the case of blkverify, the filename starts with the protocol prefix,
> follows up with the raw reference image filename and ends with the name
> of the image file.
> 
> This patch allows the configuration of both drivers completely through
> QMP and accordingly command-line options. The driver has to be selected
> through the driver option (or similar), the image filename may be given
> either as the filename itself or through a x.filename option, where "x"
> depends on the driver. Further options may be required depending on the
> driver.
> 
> In case of blkverify, the test image may be specified either through the
> filename or as a BlockdevRef reference through the "test" option. The
> raw image is referenced as "raw".
> 
> In case of blkdebug, one may either set the "config" option to the
> filename of a configuration file, or the content of the configuration
> file may be given directly (as options). The image filename is either
> specified as the filename or referenced through the "image" option.

Thanks, applied to the block branch.

I guess the next step is to untangle bdrv_file_open() and bdrv_open(),
because that part has become really confusing now... But I think this
series is a nice step forward.

Kevin