Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

[Paolo Bonzini]

Il 08/01/2014 16:07, Yan Vugenfirer ha scritto:
>>>
>>> +%QEMU-PCI_SERIAL_1_PORT%=ComPort_inst1,
>>> PCI\VEN_1B36&DEV_0002&SUBSYS_11001AF4&REV_01
>>> +%QEMU-PCI_SERIAL_2_PORT%=ComPort_inst2,
>>> PCI\VEN_1B36&DEV_0003&SUBSYS_11001AF4&REV_01
>>> +%QEMU-PCI_SERIAL_4_PORT%=ComPort_inst4,
>>> PCI\VEN_1B36&DEV_0004&SUBSYS_11001AF4&REV_01
>>
>> I think checking the subsystem is not necessary (and I think downstreams
>> could legitimately change it).  Can you check CC and REV but not SUBSYS?
> 
> PNP ID can be reduced to vendor and device ID only, for example:
> PCI\VEN_1B36&DEV_0002 . But in this case we cannot check revision.

Gerd, Michael, what do you think is better?  Not check revision, or
enforcing subsystem?

Paolo