[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in q
From: |
Loic Dachary |
Subject: |
Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests |
Date: |
Wed, 08 Jan 2014 09:22:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 08/01/2014 05:33, Stefan Hajnoczi wrote:
> On Mon, Jan 06, 2014 at 04:50:41PM +0100, Loic Dachary wrote:
>>
>>
>> On 06/01/2014 03:23, Stefan Hajnoczi wrote:
>>> On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote:
>>>> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
>>>> index 28ba0d9..af66bbd 100644
>>>> --- a/tests/qemu-iotests/common.rc
>>>> +++ b/tests/qemu-iotests/common.rc
>>>> @@ -189,7 +189,11 @@ _cleanup_test_img()
>>>> ;;
>>>>
>>>> rbd)
>>>> - rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null
>>>
>>> stderr will be displayed. Why isn't this enough?
>>>
>>
>> Because the progress of the removal operation will be displayed on stderr.
>> rbd outputs on stderr even when there is no error.
>
> Is that a bug in the rbd tool which should be fixed? Either by printing
> progress to stdout or by adding a --quiet option?
In my opinion, yes. But Josh may disagree ;-)
--
Loïc Dachary, Artisan Logiciel Libre
signature.asc
Description: OpenPGP digital signature